Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS2017 Fix #277

Merged
merged 1 commit into from
Apr 8, 2018
Merged

VS2017 Fix #277

merged 1 commit into from
Apr 8, 2018

Conversation

dilevin
Copy link
Contributor

@dilevin dilevin commented Apr 7, 2018

This is a fix for Issue #263 - "Compilation error in "newest" VIsual Studio"


This change is Reviewable

@sherm1
Copy link
Member

sherm1 commented Apr 7, 2018

I don't have the right version of VS2017 to check this but the fix looks right and makes sense to me. I verified that the CI failures are just the previously reported Mac problems and are unrelated. I think it is safe to merge this -- @SeanCurtis-TRI do you agree?


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@SeanCurtis-TRI
Copy link
Contributor

If we want to stall the weekend, I can probably test it myself. It's a shame that CI can't confirm it, but that's life. So, if we feel strongly about testing corroboration, I'll try it Monday. If we don't feel strongly, go ahead and merge (and I'll probably try it Monday anyways.)

@sherm1
Copy link
Member

sherm1 commented Apr 8, 2018

Seems better to merge it now -- I'll do that.

@sherm1 sherm1 merged commit 24cda75 into flexible-collision-library:master Apr 8, 2018
@sherm1
Copy link
Member

sherm1 commented Apr 8, 2018

Thanks, @dilevin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants