[trivial fix] remove accidental recursive include #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file should not include itself. Might seem like a cosmetic cleanup, but some code sanitizers like `include-what-you-use` fail due to this line.
SeanCurtis-TRI
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Thanks for catching that. Obviously you've got an include-what-you-use sanitizer running. :)
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
What makes you think so? 🤡 Thanks for merging right away. |
|
Well, if you make such simpler PRs that are so obviously correct, review becomes a trivial endeavor. So, thank you for making my life simple. :) |
|
So, *thank you* for making my life simple. :)
Actually, we are waiting for much more complex fixes [in other places as well](#474). ;)
Because of these failures ROS noetic probably has to bundle their own fcl package now...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file should not include itself.
Might seem like a cosmetic cleanup, but some code sanitizers like
include-what-you-usefail due to this line.This change is