Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dll path for windows in launch config json #3

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

antontsvil
Copy link
Contributor

Changes:

For easier setup in Windows environments, include an env variable for PATH rather than LD_LIBRARY_PATH which seems to be specific to Linux.

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of Rogue Legacy
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes unless there is a prior written agreement

@flibitijibibo
Copy link
Owner

I don't recall the syntax but I think we can do both by adding an OS check - I'd have to look it up. Still, definitely okay with merging this if we can get both Linux and Windows build environments working at the same time.

@antontsvil
Copy link
Contributor Author

antontsvil commented Oct 18, 2024

ooh an OS check would be ideal. This line could also just as easily be added to the README until then.

Is the os check thing something you can do in launch json? I'm more familiar with intellij

@flibitijibibo
Copy link
Owner

According to SO it appears to just be "windows": and "linux": blocks:

https://stackoverflow.com/questions/54982502/how-to-target-platforms-with-launch-json

@antontsvil
Copy link
Contributor Author

Easy enough - made the change and seems to work just fine! Have yet to double check it still works in linux though

Copy link
Owner

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - congratulations on being the first successful RL1 PR!

.vscode/launch.json Outdated Show resolved Hide resolved
@flibitijibibo flibitijibibo merged commit 64c4850 into flibitijibibo:main Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants