Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Zipkin v2 Span format #11

Open
flier opened this issue Aug 11, 2017 · 2 comments
Open

support Zipkin v2 Span format #11

flier opened this issue Aug 11, 2017 · 2 comments

Comments

@flier
Copy link
Owner

flier commented Aug 11, 2017

Zipkin v2 add a new span format (openzipkin/zipkin#1499)

@flier
Copy link
Owner Author

flier commented Aug 11, 2017

hi @adriancole,

could you help to review the changes? the test output like:

{
    "traceId": "1cc0b75520b978820a01f5444929a73a",
    "name": "test",
    "id": "fe23dadb5d05a7d9",
    "parentId": "b2f8d060661abe18",
    "kind": "CLIENT",
    "timestamp": 1502430154383331,
    "annotations": [
        {
            "timestamp": 1502430154383335,
            "value": "cs"
        }
    ],
    "tags": {
        "sa": "8.8.8.8",
        "bool": "1",
        "i16": "123",
        "i32": "123",
        "i64": "123",
        "double": "12.3",
        "string": "测试",
        "bytes": "AQID"
    }
}

@nicksbyman
Copy link
Contributor

nicksbyman commented Feb 1, 2018

Hi @adriancole and @flier do you both have a plan for merging #12? Do either of you want some help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants