Improve BSD editline compatibility #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU readline doesn't seem to ever return 0, but (e.g.) BSD editline (libedit) can return 0 (indicating that no expansion took place), while leaving the output pointer NULL. Handle return value 0 for compatibility with both libraries.
The BSD editline library (libedit, version 3.1-20221030) doesn't implement the rl_extend_line_buffer function. Alternative approaches to replace the line buffer using the readline interface don't give the desired behavior. So simply don't use history expansion in the completion function if the rl_extend_line_buffer function is not available.
rkraats
changed the title
bovine
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to allow for building/running against the BSD editline library (libedit, see https://www.thrysoee.dk/editline/) instead of GNU readline. Tested with libedit 3.1-20221030 (using configure arguments
--with-readline-includes=/usr/include/editline --with-readline-library='-ledit').Please consider merging.