Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the correct event.currentTarget on delegation #312

Closed
wants to merge 1 commit into from
Closed

Pass the correct event.currentTarget on delegation #312

wants to merge 1 commit into from

Conversation

giuseppeg
Copy link
Contributor

Removes data.el from the event data payload
Fixes #290

Removes data.el from the event data payload
Fixes #290
@tgvashworth
Copy link
Contributor

Thanks for this @giuseppeg.

For backward compatibility I'd like to keep data.el, otherwise this needs to go out with a major version bump (well, for this semver-ish project it's minor), not to mention a load of refactoring in TweetDeck. Can we just add currentTarget and the test?

@giuseppeg
Copy link
Contributor Author

@PhUU I guess we can. Let's see what the other people think about it.

@tgvashworth
Copy link
Contributor

Gonna close this cos I've put up another with some fixes (#329) — not sure of a better way to contribute to your pull!

@giuseppeg
Copy link
Contributor Author

sure np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is 'el' added to event data when using the 'this.on' delegate pattern?
2 participants