Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cu 860rc67a2 wappin v2 implement wappin v2 in GitHub library #8

Conversation

asqolani-flip
Copy link
Contributor

@asqolani-flip asqolani-flip commented Jul 31, 2023

New Feature

  • Login
  • Send Message Template
  • Unit test and Integration test included

@pianzm
Copy link
Contributor

pianzm commented Aug 4, 2023

As this is a public repository, I suggest not making dependencies into the internal package such as go-core

@asqolani-flip
Copy link
Contributor Author

asqolani-flip commented Aug 4, 2023

As this is a public repository, I suggest not making dependencies into the internal package such as go-core

currently for the go-core used for logging only mas, do you have any suggestion? do we need to remove it mas?

@pianzm
Copy link
Contributor

pianzm commented Aug 4, 2023

As this is public repository, I suggest not to make dependencies into internal package such as go-core

currently for the go-core used for logging only mas, do you have any suggestion? do we need to remove it mas?

As the purpose is only to log, we can utilize go built-in log function

@asqolani-flip
Copy link
Contributor Author

As this is public repository, I suggest not to make dependencies into internal package such as go-core

currently for the go-core used for logging only mas, do you have any suggestion? do we need to remove it mas?

As the purpose is only to log, we can utilize go built-in log function

with this https://pkg.go.dev/log ya mas?

@pianzm
Copy link
Contributor

pianzm commented Aug 4, 2023

Yes

@asqolani-flip
Copy link
Contributor Author

Yes

done mas

@asqolani-flip asqolani-flip merged commit 82ba7cd into master Aug 4, 2023
@asqolani-flip asqolani-flip deleted the CU-860rc67a2_Wappin-V2-Implement-wappin-v2-in-github-library branch August 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants