Support for Java 21 & Gradle 8.5 (#51)

flipkart-incubator · Jan 12, 2024 · a93ca90 · a93ca90
1 parent 448115d
commit a93ca90
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 12 deletions.
diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml
@@ -8,16 +8,17 @@ on:
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
-
+    strategy:
+      matrix:
+        version: [8, 17, 21]
     steps:
     - uses: actions/checkout@v3
-    - name: set up JDK 11
+    - name: set up JDK ${{ matrix.version }}
       uses: actions/setup-java@v3
       with:
-        java-version: '11'
-        distribution: 'temurin'
+        java-version: ${{ matrix.version }}
+        distribution: 'zulu'
         cache: gradle
 
     - name: Grant execute permission for gradlew

diff --git a/core/build.gradle b/core/build.gradle
@@ -57,9 +57,9 @@ dependencies {
 }
 
 task sourcesJar(type: Jar, dependsOn: classes) {
-    classifier = 'sources'
+    archiveClassifier = 'sources'
     from sourceSets.main.allSource
 }
 artifacts {
     archives sourcesJar
-}	
+}
diff --git a/core/src/main/java/com/flipkart/gjex/core/service/AbstractService.java b/core/src/main/java/com/flipkart/gjex/core/service/AbstractService.java
@@ -185,4 +185,4 @@ public void setStopTimeout(long stopTimeout) {
 		this.stopTimeout = stopTimeout;
 	}
 
-}
+}
diff --git a/examples/build.gradle b/examples/build.gradle
@@ -21,7 +21,7 @@ repositories {
 def jexpressVersion = '1.39-SNAPSHOT'
 def grpcVersion = '1.38.0'
 def protobufVersion = '3.12.0'
-def protocVersion = protobufVersion
+def protocVersion = protobufVersion 
 
 dependencies {
     implementation "com.flipkart.grpc-jexpress:core:${jexpressVersion}"
@@ -74,6 +74,15 @@ task helloWorldServer(type: CreateStartScripts) {
     classpath = startScripts.classpath
 }
 
+task runHelloWorldServer(type: JavaExec) {
+    group = "Execution"
+    description = "run hello-world-server"
+    classpath = sourceSets.main.runtimeClasspath
+    mainClass = 'com.flipkart.gjex.examples.helloworld.HelloWorldApplication'
+    args "server", "./src/main/resources/hello_world_config.yml"
+    jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
+}
+
 
 task helloWorldClient(type: CreateStartScripts) {
     mainClassName = 'com.flipkart.gjex.examples.helloworld.client.HelloWorldClient'
@@ -82,6 +91,14 @@ task helloWorldClient(type: CreateStartScripts) {
     classpath = startScripts.classpath
 }
 
+task runHelloWorldClient(type: JavaExec) {
+    group = "Execution"
+    description = "run hello-world-client"
+    classpath = sourceSets.main.runtimeClasspath
+    mainClass = 'com.flipkart.gjex.examples.helloworld.client.HelloWorldClient'
+    jvmArgs '--add-opens=java.base/java.lang=ALL-UNNAMED'
+}
+
 applicationDistribution.into('bin') {
     from(helloWorldServer)
     from(helloWorldClient)

diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
diff --git a/guice/build.gradle b/guice/build.gradle
@@ -60,7 +60,7 @@ dependencies {
 }
 
 task sourcesJar(type: Jar, dependsOn: classes) {
-    classifier = 'sources'
+    archiveClassifier = 'sources'
     from sourceSets.main.allSource
 }
 artifacts {

diff --git a/runtime/build.gradle b/runtime/build.gradle
@@ -39,7 +39,7 @@ dependencies {
 }
 
 task sourcesJar(type: Jar, dependsOn: classes) {
-    classifier = 'sources'
+    archiveClassifier = 'sources'
     from sourceSets.main.allSource
 }
 artifacts {
-Original file line number
+Diff line change
@@ Expand Up / @@ -185,4 +185,4 @@ public void setStopTimeout(long stopTimeout) { @@
     		this.stopTimeout = stopTimeout;
     	}
-    }
+    }