Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dw-metrics stable 4.x #118

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Switch to dw-metrics stable 4.x #118

merged 5 commits into from
Dec 13, 2024

Conversation

kingster
Copy link
Member

@kingster kingster commented Dec 12, 2024

Why switch to 4.x ?
dw-metrics5 isn't stable yet, and the ecosystem is yet to adopt the metrics5, hence most of the third-party libraries still uses com.codahale.metrics and the given that the p8s bridge is now supported for metrics4 it makes sense to switch to the lower stable version which is easier with the ecosystem.

Depends on client_java#867

@kingster kingster marked this pull request as ready for review December 12, 2024 04:25
@kingster kingster merged commit 7bc0576 into master Dec 13, 2024
3 checks passed
@kingster kingster deleted the metrics-4 branch December 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant