Merge pull request #12 from flipkart-incubator/okhttp

downgrade okhttp version as it has breaking changes
flipkart-incubator · May 29, 2020 · 872460f · 872460f
2 parents 52efad7 + b5dd8f3
commit 872460f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/madman-okhttp/build.gradle b/madman-okhttp/build.gradle
@@ -64,7 +64,7 @@ dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
     implementation 'androidx.appcompat:appcompat:1.1.0'
     implementation 'androidx.core:core-ktx:1.2.0'
-    api 'com.squareup.okhttp3:okhttp:4.4.0'
+    api 'com.squareup.okhttp3:okhttp:3.14.4'
     implementation project(':madman')
 
     testImplementation 'junit:junit:4.12'

diff --git a/madman-okhttp/src/main/java/com/flipkart/madman/okhttp/extension/DefaultNetworkLayer.kt b/madman-okhttp/src/main/java/com/flipkart/madman/okhttp/extension/DefaultNetworkLayer.kt
@@ -103,13 +103,13 @@ open class DefaultNetworkLayer(private val context: Context) : NetworkLayer,
     override fun onResponse(call: Call, response: Response) {
         if (response.isSuccessful) {
             resultListener?.onSuccess(
-                response.code,
-                response.body?.string()
+                response.code(),
+                response.body()?.string()
             )
         } else {
             resultListener?.onError(
-                response.code,
-                response.body?.string() ?: ERROR_MESSAGE
+                response.code(),
+                response.body()?.string() ?: ERROR_MESSAGE
             )
         }
     }

diff --git a/madman/src/main/java/com/flipkart/madman/component/enums/AdEventType.kt b/madman/src/main/java/com/flipkart/madman/component/enums/AdEventType.kt
@@ -19,6 +19,7 @@ package com.flipkart.madman.component.enums
  * List of all ad events sent to the client.
  */
 enum class AdEventType {
+    CUEPOINTS_CHANGED,
     STARTED,
     PAUSED,
     RESUMED,