Skip to content

Commit

Permalink
[FL-2548] Infrared: show error if no SD card/databases (#1337)
Browse files Browse the repository at this point in the history
* Add Database error scene
* More general popup callback name
  • Loading branch information
gsurkov authored Jun 21, 2022
1 parent eb31fed commit 92f763e
Show file tree
Hide file tree
Showing 11 changed files with 66 additions and 12 deletions.
8 changes: 5 additions & 3 deletions applications/infrared/infrared.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ static const NotificationSequence* infrared_notification_sequences[] = {
&sequence_set_only_green_255,
&sequence_reset_green,
&sequence_blink_cyan_10,
&sequence_blink_magenta_10};
&sequence_blink_magenta_10,
&sequence_solid_yellow,
&sequence_reset_rgb};

static void infrared_make_app_folder(Infrared* infrared) {
if(!storage_simply_mkdir(infrared->storage, INFRARED_APP_FOLDER)) {
Expand Down Expand Up @@ -360,11 +362,11 @@ void infrared_text_input_callback(void* context) {
infrared->view_dispatcher, InfraredCustomEventTypeTextEditDone);
}

void infrared_popup_timeout_callback(void* context) {
void infrared_popup_closed_callback(void* context) {
furi_assert(context);
Infrared* infrared = context;
view_dispatcher_send_custom_event(
infrared->view_dispatcher, InfraredCustomEventTypePopupTimeout);
infrared->view_dispatcher, InfraredCustomEventTypePopupClosed);
}

int32_t infrared_app(void* p) {
Expand Down
2 changes: 1 addition & 1 deletion applications/infrared/infrared_custom_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ enum InfraredCustomEventType {
InfraredCustomEventTypeTransmitStopped,
InfraredCustomEventTypeSignalReceived,
InfraredCustomEventTypeTextEditDone,
InfraredCustomEventTypePopupTimeout,
InfraredCustomEventTypePopupClosed,
InfraredCustomEventTypeButtonSelected,
InfraredCustomEventTypeBackPressed,
};
Expand Down
4 changes: 3 additions & 1 deletion applications/infrared/infrared_i.h
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ typedef enum {
InfraredNotificationMessageGreenOff,
InfraredNotificationMessageBlinkRead,
InfraredNotificationMessageBlinkSend,
InfraredNotificationMessageYellowOn,
InfraredNotificationMessageYellowOff,
} InfraredNotificationMessage;

bool infrared_add_remote_with_button(Infrared* infrared, const char* name, InfraredSignal* signal);
Expand All @@ -129,4 +131,4 @@ void infrared_show_loading_popup(Infrared* infrared, bool show);
void infrared_signal_sent_callback(void* context);
void infrared_signal_received_callback(void* context, InfraredWorkerSignal* received_signal);
void infrared_text_input_callback(void* context);
void infrared_popup_timeout_callback(void* context);
void infrared_popup_closed_callback(void* context);
1 change: 1 addition & 0 deletions applications/infrared/scenes/infrared_scene_config.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@ ADD_SCENE(infrared, remote_list, RemoteList)
ADD_SCENE(infrared, universal, Universal)
ADD_SCENE(infrared, universal_tv, UniversalTV)
ADD_SCENE(infrared, debug, Debug)
ADD_SCENE(infrared, error_databases, ErrorDatabases)
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ void infrared_scene_edit_delete_done_on_enter(void* context) {
popup_set_icon(popup, 0, 2, &I_DolphinMafia_115x62);
popup_set_header(popup, "Deleted", 83, 19, AlignLeft, AlignBottom);

popup_set_callback(popup, infrared_popup_timeout_callback);
popup_set_callback(popup, infrared_popup_closed_callback);
popup_set_context(popup, context);
popup_set_timeout(popup, 1500);
popup_enable_timeout(popup);
Expand All @@ -21,7 +21,7 @@ bool infrared_scene_edit_delete_done_on_event(void* context, SceneManagerEvent e
bool consumed = false;

if(event.type == SceneManagerEventTypeCustom) {
if(event.event == InfraredCustomEventTypePopupTimeout) {
if(event.event == InfraredCustomEventTypePopupClosed) {
const InfraredEditTarget edit_target = infrared->app_state.edit_target;
if(edit_target == InfraredEditTargetButton) {
scene_manager_search_and_switch_to_previous_scene(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ void infrared_scene_edit_rename_done_on_enter(void* context) {
popup_set_icon(popup, 32, 5, &I_DolphinNice_96x59);
popup_set_header(popup, "Saved!", 5, 7, AlignLeft, AlignTop);

popup_set_callback(popup, infrared_popup_timeout_callback);
popup_set_callback(popup, infrared_popup_closed_callback);
popup_set_context(popup, context);
popup_set_timeout(popup, 1500);
popup_enable_timeout(popup);
Expand All @@ -20,7 +20,7 @@ bool infrared_scene_edit_rename_done_on_event(void* context, SceneManagerEvent e
bool consumed = false;

if(event.type == SceneManagerEventTypeCustom) {
if(event.event == InfraredCustomEventTypePopupTimeout) {
if(event.event == InfraredCustomEventTypePopupClosed) {
scene_manager_next_scene(infrared->scene_manager, InfraredSceneRemote);
consumed = true;
}
Expand Down
37 changes: 37 additions & 0 deletions applications/infrared/scenes/infrared_scene_error_databases.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#include "../infrared_i.h"

void infrared_scene_error_databases_on_enter(void* context) {
Infrared* infrared = context;
Popup* popup = infrared->popup;

popup_set_icon(popup, 5, 11, &I_SDQuestion_35x43);
popup_set_text(
popup, "Function requires\nSD card with fresh\ndatabases.", 47, 17, AlignLeft, AlignTop);

popup_set_context(popup, context);
popup_set_callback(popup, infrared_popup_closed_callback);

infrared_play_notification_message(infrared, InfraredNotificationMessageYellowOn);
view_dispatcher_switch_to_view(infrared->view_dispatcher, InfraredViewPopup);
}

bool infrared_scene_error_databases_on_event(void* context, SceneManagerEvent event) {
Infrared* infrared = context;
bool consumed = false;

if(event.type == SceneManagerEventTypeCustom) {
if(event.event == InfraredCustomEventTypePopupClosed) {
scene_manager_search_and_switch_to_previous_scene(
infrared->scene_manager, InfraredSceneUniversal);
consumed = true;
}
}

return consumed;
}

void infrared_scene_error_databases_on_exit(void* context) {
Infrared* infrared = context;
popup_reset(infrared->popup);
infrared_play_notification_message(infrared, InfraredNotificationMessageYellowOff);
}
4 changes: 2 additions & 2 deletions applications/infrared/scenes/infrared_scene_learn_done.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ void infrared_scene_learn_done_on_enter(void* context) {
popup_set_header(popup, "Saved!", 5, 7, AlignLeft, AlignTop);
}

popup_set_callback(popup, infrared_popup_timeout_callback);
popup_set_callback(popup, infrared_popup_closed_callback);
popup_set_context(popup, context);
popup_set_timeout(popup, 1500);
popup_enable_timeout(popup);
Expand All @@ -28,7 +28,7 @@ bool infrared_scene_learn_done_on_event(void* context, SceneManagerEvent event)
bool consumed = false;

if(event.type == SceneManagerEventTypeCustom) {
if(event.event == InfraredCustomEventTypePopupTimeout) {
if(event.event == InfraredCustomEventTypePopupClosed) {
scene_manager_next_scene(infrared->scene_manager, InfraredSceneRemote);
consumed = true;
}
Expand Down
2 changes: 1 addition & 1 deletion applications/infrared/scenes/infrared_scene_universal_tv.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void infrared_scene_universal_tv_on_enter(void* context) {
infrared_show_loading_popup(infrared, false);

if(!success) {
scene_manager_previous_scene(infrared->scene_manager);
scene_manager_next_scene(infrared->scene_manager, InfraredSceneErrorDatabases);
}
}

Expand Down
9 changes: 9 additions & 0 deletions applications/notification/notification_messages.c
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,15 @@ const NotificationSequence sequence_set_blue_255 = {
NULL,
};

// Solid colors
const NotificationSequence sequence_solid_yellow = {
&message_red_255,
&message_green_255,
&message_blue_0,
&message_do_not_reset,
NULL,
};

// Blink
const NotificationSequence sequence_blink_blue_10 = {
&message_blue_255,
Expand Down
3 changes: 3 additions & 0 deletions applications/notification/notification_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ extern const NotificationSequence sequence_set_red_255;
extern const NotificationSequence sequence_set_green_255;
extern const NotificationSequence sequence_set_blue_255;

// Solid colors
extern const NotificationSequence sequence_solid_yellow;

// Blink
extern const NotificationSequence sequence_blink_blue_10;
extern const NotificationSequence sequence_blink_red_10;
Expand Down

0 comments on commit 92f763e

Please sign in to comment.