Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

125 kHz/LFRFID - New Feature - Direct Emulation #1371

Closed
wants to merge 11 commits into from
Closed

125 kHz/LFRFID - New Feature - Direct Emulation #1371

wants to merge 11 commits into from

Conversation

atomsmasha
Copy link

What's new

  • New Menu item for the 125 kHz/LFRFID application - "Emulate Directly"
  • Allows you to select a protocol, enter the hex digits, and emulate immediately - bypassing the need to load/save files

Created some new scenes in applications/lfrfid/scenes:

  • lfrfid_app_scene_emu_data
  • lfrfid_app_scene_emu_menu
  • Also updated some core files to enumerate the new scenes (i messed up the diff so i'm very sorry about that, the only updates I made were in line with the established pattern and do not touch any logic)

Verification

  • Recompile the firmware and load it on ur flipper
  • Check "125 kHz RFID" application for a 4th menu item - Emulate Directly
  • Select protocol
  • Enter hex digits and hit "save"
  • Flippy should now be emulating the digits u entered
  • Hitting back will take u back to byte edit screen

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

atomsmasha added 9 commits July 5, 2022 14:15
@atomsmasha
LFRFID - Direct Emulation
a841abc 
Adding a new root menu item to the 125 kHz/LFRFID app - "Direct Emulation"
- Updating core app files to link new scenes
@atomsmasha
LFRFID - Direct Emulation
44bab7d 
Adding a new root menu item to the 125 kHz/LFRFID app - "Direct Emulation"
- New scenes to support the feature
- Adding new menu item to lfrfid_app_scene_start.cpp
@atomsmasha
Update lfrfid_app.cpp
6c68e13 
adding newline to EOF
@atomsmasha
Update lfrfid_app.h
fa9dc90 
adding newline to EOF
@atomsmasha
Update lfrfid_app_scene_emu_data.cpp
0d3960d 
adding newline to EOF
@atomsmasha
Update lfrfid_app_scene_emu_data.h
f1325a8 
adding newline to EOF
@atomsmasha
Update lfrfid_app_scene_emu_menu.cpp
d19f0f7 
adding newline to EOF
@atomsmasha
Update lfrfid_app_scene_emu_menu.h
f91e773 
adding newline to EOF
@atomsmasha
Update lfrfid_app_scene_start.cpp
4267d54 
adding newline to EOF
atomsmasha added 2 commits July 5, 2022 19:53
@atomsmasha
Update lfrfid_app.h
3c5b08f 
merging in my changes - didn't see that dev branch had been updated by @skotopes recently
@atomsmasha
LFRFID - Direct Emu - merging in changes after flipperdevices#1350
3c923e4 
merging in my changes - didn't see that dev branch had been updated by @skotopes recently
@skotopes
Copy link
Member

skotopes commented Jul 5, 2022

Hi @atomsmasha

We can not accept this pull request because:

  • from UI/UX point of perspective this function duplicates normal create-save-emulate flow.
  • Rfid application is currently being rewritten in C and we accepting only major improvements.

PS: when implementing something big please talk with us (in guthub issue, on discord) so we'll be able to provide support and guarantee that your PR will be accepted.

@skotopes skotopes closed this Jul 5, 2022
@atomsmasha
Copy link
Author

Hi @skotopes
Thanks for the review - noted RE: discord
Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atomsmasha @skotopes