Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New frequency analyzer #1557

Closed
wants to merge 3 commits into from
Closed

New frequency analyzer #1557

wants to merge 3 commits into from

Conversation

ClusterM
Copy link

@ClusterM ClusterM commented Aug 8, 2022 •
edited
Loading

Reopened pull request.

What's new

New frequency analyzer view:

  • Ability to set RSSI trigger level
  • Sound and vibration on signal detect
  • The last triggered frequency is displayed
  • The interface looks better
  • Sensitivity increased

image

Verification

  • Start "Sub-GHz"
  • Select "Frequency Analyzer"
  • Check out the new Frequency Analyzer!
  • Try to generate any signal nearby
  • "Success" sound and vibration should be played
  • The last frequency value and the last RSSI level should be displayed
  • You can press left and right to set RSSI trigger level

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@ClusterM ClusterM mentioned this pull request Aug 8, 2022
Closed
3 tasks
@Astrrra
Copy link
Member

Astrrra commented Aug 8, 2022

The sensitivity was intentionally set low by design, to filter out noise. Did you just increase it, or is there some way to change it now?

@m1ga
Copy link

m1ga commented Aug 8, 2022

@ClusterM works fine 👍 awesome PR. would it be possible to add "up" to toggle sound on/off? Sometimes you don't want to hear it 😉

@ClusterM
Copy link
Author

ClusterM commented Aug 8, 2022

@ClusterM works fine 👍 awesome PR. would it be possible to add "up" to toggle sound on/off? Sometimes you don't want to hear it 😉

It's possible but I'm not sure how to show it in GUI.

@hedger hedger added Sub-GHz Sub-GHz-related UI Affects UI labels Aug 9, 2022
@ClusterM
Copy link
Author

The sensitivity was intentionally set low by design, to filter out noise. Did you just increase it, or is there some way to change it now?

You can change trigger level now. It affects sound and "last" value.

@ClusterM
Copy link
Author

The sensitivity was intentionally set low by design, to filter out noise. Did you just increase it, or is there some way to change it now?

Fixed, it changes with trigger level now.

xMasterX referenced this pull request in DarkFlippers/unleashed-firmware Aug 10, 2022
@xMasterX
Update Frequency analyzer by @ClusterM
91c7441 
OFW PR #1557
RogueMaster added a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Aug 11, 2022
@RogueMaster
New frequency analyzer flipperdevices#1557 (By ClusterM)] UPDATED
35f7906
bdryanovski pushed a commit to bdryanovski/flipperzero-firmware that referenced this pull request Aug 19, 2022
Feat: adding keyboard change and update frequency analyzer flipperdev…
ecc9082 
…ices#1557

Signed-off-by: bdryanovski <bozhidar.dryanovski@theopentag.com>
Himura2la
Himura2la reviewed Sep 6, 2022
View reviewed changes
applications/subghz/views/subghz_frequency_analyzer.c
if((rssi == 0.f) && (instance->locked)) {
if(instance->callback) {
instance->callback(SubGhzCustomEventSceneAnalyzerUnlock, instance->context);
notification_message(instance->notifications, &sequence_hw_blink);
Copy link
Contributor

@Himura2la Himura2la Sep 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClusterM I'm not sure, that's a good idea to blink while scanning. It was convenient when Flipper blinked only when it senses a signal. Now it's harder to detect the moment when I need to pay attention to the screen. I'd rather disable constant blinking both here and in Read/Read RAW mode, because it may draw unwanted attention when using in public spaces, and restore the subghz_scene_frequency_analyzer_on_event function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ClusterM/flipperzero-firmware/pull/1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And my PR with Read/Read RAW flashing disabled: #1745

@skotopes
Copy link
Member

skotopes commented Oct 8, 2022

Please talk with @Skorpionm regarding this PR.

@skotopes skotopes closed this Oct 8, 2022
@derskythe derskythe mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himura2la Himura2la Himura2la left review comments

@skotopes skotopes Awaiting requested review from skotopes skotopes is a code owner

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm

Assignees

@Skorpionm Skorpionm

Labels
Sub-GHz Sub-GHz-related UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ClusterM @Astrrra @m1ga @skotopes @Himura2la @hedger @Skorpionm