Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3679] iButton new UI #3471

Merged
merged 6 commits into from
Apr 17, 2024
Merged

[FL-3679] iButton new UI #3471

merged 6 commits into from
Apr 17, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Feb 21, 2024 •
edited by skotopes
Loading

What's new

  • iButton new UI

Verification

  • Check iButton app

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@Astrrra Astrrra marked this pull request as ready for review February 25, 2024 23:10
@hedger hedger added UI Affects UI iButton labels Feb 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

Compiled f7 firmware for commit ce4a16c7:

@github-actions GitHub Actions
Copy link

PVS-Studio report for commit 0878682f:

@skotopes skotopes marked this pull request as draft March 20, 2024 21:59
@Astrrra Astrrra marked this pull request as ready for review April 10, 2024 22:27
@skotopes skotopes merged commit 4883383 into dev Apr 17, 2024
11 checks passed
@skotopes skotopes deleted the astra/3679-ibutton-ui branch April 17, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
iButton UI Affects UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astrrra @skotopes @hedger