Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting view_dispatcher callbacks to NULL again #3580

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

xMasterX
Copy link
Contributor

@xMasterX xMasterX commented Apr 10, 2024

What's new

  • Allow setting view_dispatcher callbacks to NULL again
  • Checks for callback existence is already present in the code
  • Recently added furi_check removes ability to remove callback without freeing whole view_dispatcher, which breaks logic in some Apps

Verification

  • Check that view_dispatcher_set_custom_event_callback(view_dispatcher, NULL) can be called in apps now again
  • All working fine

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

@xMasterX I've checked flipper-xremote source code and it's kinda puzzling, clearly not how we want people to use GUI.
I'm going to accept this PR, but I still don't see valid use case for changing callbacks on fly.

@skotopes skotopes merged commit 00970a4 into flipperdevices:dev Apr 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants