Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFC: fix BIP plugin #3595

Merged
merged 2 commits into from
Apr 18, 2024
Merged

NFC: fix BIP plugin #3595

merged 2 commits into from
Apr 18, 2024

Conversation

gornekich
Copy link
Member

@gornekich gornekich commented Apr 16, 2024 •
edited by skotopes
Loading

What's new

  • Fix false positive verification in BIP plugin

Verification

  • BIP plugin doesn't read not BIP card

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Compiled f7 firmware for commit 1145f35d:

@gornekich gornekich mentioned this pull request Apr 16, 2024
Closed
@skotopes skotopes merged commit be43e49 into dev Apr 18, 2024
11 checks passed
@skotopes skotopes deleted the gornek/bip_plugin_fix_false_positive branch April 18, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gornekich @skotopes