Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updater: slightly smaller image #3740

Merged
merged 3 commits into from
Jul 2, 2024
Merged

updater: slightly smaller image #3740

merged 3 commits into from
Jul 2, 2024

Conversation

hedger
Copy link
Member

@hedger hedger commented Jun 30, 2024 •
edited by skotopes
Loading

What's new

  • updater: eliminated all uses of float formatting
  • libs: print: disabled float/double printf support in updater builds
  • results in smaller (~2-3k) updater image

Verification

  • run update and check that everything is OK
  • validate that float prints are not used in resulting image (strings dist/f7-D/flipper-z-f7-updater-local.bin | grep %f)

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2024 •
edited
Loading

Compiled f7 firmware for commit c196b3a7:

@hedger hedger added the Core+Services HAL, furi & core system services label Jun 30, 2024
@skotopes skotopes merged commit 9565806 into dev Jul 2, 2024
11 checks passed
@skotopes skotopes deleted the hedger/updater_no_printf_floats branch July 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes