Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3865] Fix iButton/LFRFID Add Manually results being discarded #3749

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[FL-3865] Fix iButton/LFRFID Add Manually results being discarded #3749

merged 2 commits into from
Jul 3, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Jul 3, 2024 •
edited
Loading

What's new

Verification

  • Check that Add Manually works as expected in LFRFID and iButton

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Compiled f7 firmware for commit 161aafb5:

@Astrrra Astrrra marked this pull request as ready for review July 3, 2024 09:41
@skotopes skotopes merged commit 2715d9a into dev Jul 3, 2024
11 checks passed
@skotopes skotopes deleted the astra/3752-rfid-name-fixes branch July 3, 2024 11:44
@Astrrra Astrrra changed the title [FL-3752] Fix iButton/LFRFID Add Manually results being discarded [FL-3685] Fix iButton/LFRFID Add Manually results being discarded Jul 4, 2024
@Astrrra Astrrra changed the title [FL-3685] Fix iButton/LFRFID Add Manually results being discarded [FL-3865] Fix iButton/LFRFID Add Manually results being discarded Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @skotopes