Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: seaprate callbacks for dolphin and storage subscriptions #3836

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Desktop: seaprate callbacks for dolphin and storage subscriptions #3836

merged 2 commits into from
Aug 12, 2024

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Aug 12, 2024 •
edited by hedger
Loading

What's new

  • Desktop: seaprate callbacks for dolphin and storage subscriptions

Verification

  • Check desktop reaction to SD-Card insert event
  • Check desktop reaction to Dolphin deed event

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

Compiled f7 firmware for commit 07dad684:

@hedger hedger added Bug Core+Services HAL, furi & core system services labels Aug 12, 2024
@skotopes skotopes merged commit 702db89 into dev Aug 12, 2024
11 checks passed
@skotopes skotopes deleted the aku/desktop_fix branch August 12, 2024 00:51
ofabel pushed a commit to ofabel/flipperzero-firmware that referenced this pull request Sep 26, 2024
@skotopes @hedger @ofabel
Desktop: seaprate callbacks for dolphin and storage subscriptions (fl…
91d9f1d 
…ipperdevices#3836)

* Desktop: seaprate callbacks for dolphin and storage subscriptions
* dolphin: renamed local variable to prevent unintended overrides

Co-authored-by: hedger <hedger@nanode.su>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Bug Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skotopes @hedger