[FL-3897] Happy mode #3863
Merged
[FL-3897] Happy mode #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled f7 firmware for commit |
portasynthinca3
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov and
nminaylov
as code owners
skotopes
requested changes
Sep 5, 2024
applications/settings/desktop_settings/scenes/desktop_settings_scene_happy_mode.c
Outdated
Show resolved
Hide resolved
applications/settings/power_settings_app/scenes/power_settings_scene_power_off.c
Outdated
Show resolved
Hide resolved
skotopes
requested changes
Sep 5, 2024
portasynthinca3
force-pushed
the
portasynthinca3/3897-happy-mode
branch
from
8493607 to
185d51b
Compare
skotopes
requested changes
Sep 6, 2024
skotopes
requested changes
Sep 6, 2024
skotopes
previously approved these changes
Sep 7, 2024
skotopes
approved these changes
Sep 7, 2024
|
Thank you ❤️ |
ofabel
pushed a commit
to ofabel/flipperzero-firmware
that referenced
this pull request
Sep 26, 2024
* feat: happy mode * feat: remove sad dolphin when powering off in happy mode * style: address review comments * Dolphin: add missing furi_checks * Komi: add missing region initialization on startup Co-authored-by: あく <alleteam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Added a mode in which the dolphin never gets angry, as requested in #3843. This mode can be toggled via Settings > Desktop > Happy Mode with different screens displayed depending on whether the setting is currently enabled or disabled:
This is implemented by always reporting the internal
butthurtcounter as being at zero when the setting is enabled.In addition, the "Power OFF" screen will never show the sad dolphin when this mode is enabled:
Verification
DOLPHIN_DEBUGin order to decrease waiting timesChecklist (For Reviewer)