FuriTimer: Use an event instead of a volatile bool to wait for deletion #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookiePLMonster
requested review from
skotopes,
DrZlo13,
hedger and
gsurkov
as code owners
skotopes
approved these changes
Sep 8, 2024
ofabel
pushed a commit
to ofabel/flipperzero-firmware
that referenced
this pull request
Sep 26, 2024
…on (flipperdevices#3887) Co-authored-by: あく <alleteam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Further improves over #3865, now
furi_timer_freeuses an event to wait for the timer to be deleted instead of looping on a volatile bool.FuriThreadcould benefit from something similar too, but the event would have to be made part of the thread structure, so it's not worth it at the moment.Verification
Checklist (For Reviewer)