Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Mouse Clicker Should have a "0" value setting for "as fast as possible" #3876 #3894

Merged
merged 3 commits into from
Oct 14, 2024

Hid: limit max clicks to 100/s, rewrite code to make it more robust

ea3b55f
Select commit
Loading
Failed to load commit list.
Merged

Fixes Mouse Clicker Should have a "0" value setting for "as fast as possible" #3876 #3894

Hid: limit max clicks to 100/s, rewrite code to make it more robust
ea3b55f
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Oct 14, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
HID App: allow 0 in mouse clicker, treat it as max rate Incomplete
Check BLE/USB Remote apps Incomplete
PR has description of feature/bug or link to Confluence/Jira task Completed
Description contains actions to verify feature/bugfix Completed
I've built this code, uploaded it to the device and verified feature/bugfix Completed
delay in timer callback make no sense, instead you can adjust interval Incomplete
BLE HID events reporting got it's own limitations, exceeding 100 events per second will cause issues Incomplete
I've limited max events to 100/s, more is possible but system will be unstable Incomplete