Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Furi: A Lot of Fixes #3942

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Furi: A Lot of Fixes #3942

merged 3 commits into from
Oct 14, 2024

Conversation

skotopes
Copy link
Member

@skotopes skotopes commented Oct 13, 2024 •
edited
Loading

What's new

  • BT Service: cleanup code
  • Dialog: correct release order in file browser, fix various crashes and bus faults
  • Rpc: rollback to pre FuriThread: Improve state callbacks #3881 state, fix deadlock on gui rpc shutdown
  • Kernel: fix inverted behavior in furi_kernel_is_running, make it usable
  • Log: properly take mutex when kernel is not running, prevent crash if kernel is not fully running
  • Thread: rework tread control block scrubbing procedure, ensure that we don't do stupid things in idle task, add new priority for init task, prevent various deadlocks
  • Timer: add control queue flush method, force flush on stop, prevent use after free if timers are incorrectly used
  • Furi: system init task now performs thread scrubbing, delay now ensures that you are not using it from the idle task
  • BleGlue: add some extra checks
  • FreeRTOSConfig: fix bunch of issues that were preventing configuration from being properly applied and cleanup dead things

Verification

  • Full set of integration tests
  • No more lockup on BLE RCP streaming and profile change at the same time
  • No more rare bus faults on app start

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
- BT Service: cleanup code
6a4e9e3 
- Dialog: correct release order in file browser
- Rpc: rollback to pre #3881 state
- Kernel: fix inverted behavior in furi_kernel_is_running
- Log: properly take mutex when kernel is not running
- Thread: rework tread control block scrubbing procedure, ensure that we don't do stupid things in idle task, add new priority for init task
- Timer: add control queue flush method, force flush on stop
- Furi: system init task now performs thread scrubbing
- BleGlue: add some extra checks
- FreeRTOSConfig: fix bunch of issues that were preventing configuration from being properly applied and cleanup
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

Compiled f7 firmware for commit e74e2d25:

@hedger hedger self-assigned this Oct 13, 2024
@hedger hedger added Bug Core+Services HAL, furi & core system services Bluetooth labels Oct 13, 2024
gsurkov
gsurkov previously approved these changes Oct 14, 2024
View reviewed changes
@skotopes skotopes merged commit 5190aac into dev Oct 14, 2024
11 checks passed
@skotopes skotopes deleted the aku/pandorum branch October 14, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 DrZlo13 approved these changes

@gsurkov gsurkov gsurkov left review comments

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees

@hedger hedger

Labels
Bluetooth Bug Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skotopes @DrZlo13 @gsurkov @hedger