Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FurEventLoop: add support for FuriEventFlag, simplify API #3958

Merged
merged 25 commits into from
Oct 31, 2024
Merged

FurEventLoop: add support for FuriEventFlag, simplify API #3958

merged 25 commits into from
Oct 31, 2024

Conversation

Skorpionm
Copy link
Member

@Skorpionm Skorpionm commented Oct 17, 2024 •
edited by skotopes
Loading

What's new

  • FuriEventLoop:
    • FuriEventFlag integration
    • Abolish callback return value (Level events are now always rescheduled)
    • Update docs
  • Unit tests:
    • (NEW) FuriEventFlag, FuriSemaphore, FuriStreamBuffer
    • Refactoring
    • Add stub tests for Furi OS-level primitives
  • Examples: FuriEventFlag example

Verification

  1. Run unit tests (everything should be OK)
  2. Run the new example application: 
    ./fbt launch APPSRC=example_event_loop_event_flags
    Press some buttons and observe the debug output.
  3. Use the firmware normally, no regressions should be present.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Compiled f7 firmware for commit 98516dfd:

@skotopes skotopes marked this pull request as ready for review October 17, 2024 15:47
@Skorpionm Skorpionm marked this pull request as draft October 18, 2024 14:32
@gsurkov gsurkov changed the title Event_loop: add support event_flag FurEventLoop: add support for FuriEventFlag, simplify API Oct 21, 2024
@gsurkov gsurkov marked this pull request as ready for review October 22, 2024 15:20
skotopes
skotopes previously approved these changes Oct 31, 2024
View reviewed changes
@skotopes skotopes merged commit 6d82383 into dev Oct 31, 2024
11 checks passed
@skotopes skotopes deleted the skorp/event_loop_event_flag branch October 31, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skorpionm @skotopes @gsurkov