Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3922] Fix JS memory corruption #3971

Merged
merged 3 commits into from
Oct 31, 2024
Merged

[FL-3922] Fix JS memory corruption #3971

merged 3 commits into from
Oct 31, 2024

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Oct 23, 2024 •
edited by skotopes
Loading

What's new

Fixed incorrect usage of mjs_own that used to lead to crashes in garbage collector intensive scripts, such as @rnadyrshin's bitbanged I2C implementation.

Verification

  • Verify that unit tests and example scripts still work as intended
  • @rnadyrshin, please verify that your implementation doesn't crash anymore

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3 portasynthinca3 added Bug JS JS Runtime, loader and API labels Oct 23, 2024
@portasynthinca3 portasynthinca3 marked this pull request as draft October 23, 2024 17:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

Compiled f7 firmware for commit d4ffe24a:

@rnadyrshin
Copy link
Contributor

@portasynthinca3
It works great! Crashes don't happen anymore
Thank you!

@portasynthinca3 portasynthinca3 marked this pull request as ready for review October 24, 2024 09:57
@skotopes skotopes merged commit 72272b3 into dev Oct 31, 2024
11 checks passed
@skotopes skotopes deleted the portasynthinca3/3922-gpio-crash branch October 31, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

Assignees
No one assigned
Labels
Bug JS JS Runtime, loader and API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portasynthinca3 @rnadyrshin @skotopes