Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: Fix BusFault in handling of OOM #3992

Merged
merged 3 commits into from
Dec 18, 2024

Furi: fix crash in aligned_alloc, cleanup aligned_alloc use

0e24a20
Select commit
Loading
Failed to load commit list.
Merged

Loader: Fix BusFault in handling of OOM #3992

Furi: fix crash in aligned_alloc, cleanup aligned_alloc use
0e24a20
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 18, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
during OOM propagation, ELF file has small chance of trying to free relocation data that is not allocated: Incomplete
elf_load_section_data() does not allocate fast_rel->data if not enough ram Incomplete
but elf_preload_section() allocated fast_rel itself, so both would try to be freed when only 1 exists Incomplete
in particular, this was observable in upython app Incomplete
try to run upython app Incomplete
either it opens, or it gives out of memory message, not crash Incomplete
PR has description of feature/bug or link to Confluence/Jira task Completed
Description contains actions to verify feature/bugfix Completed
I've built this code, uploaded it to the device and verified feature/bugfix Completed