Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FL-3920] Fix lost BadBLE keystrokes #3993

Merged
merged 15 commits into from
Dec 23, 2024
Merged

[FL-3920] Fix lost BadBLE keystrokes #3993

merged 15 commits into from
Dec 23, 2024

Conversation

Astrrra
Copy link
Member

@Astrrra Astrrra commented Nov 7, 2024 •
edited by skotopes
Loading

What's new

  • BadBLE shouldn't drop keystrokes when log level is at Default or less

Verification

  • The changes in this PR cover commonly used BLE api methods, so all aspects of BLE communication should be tested, not only BadBLE

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Compiled f7 firmware for commit b920cb40:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

PVS-Studio report for commit d660eb47:

@Astrrra Astrrra changed the title [FL-3920] WIP: fix lost BadBLE keystrokes [FL-3920] Fix lost BadBLE keystrokes Nov 26, 2024
@Astrrra Astrrra marked this pull request as ready for review November 26, 2024 10:41
skotopes
skotopes requested changes Dec 18, 2024
View reviewed changes
targets/f7/ble_glue/gap.c Outdated Show resolved Hide resolved
@skotopes skotopes marked this pull request as draft December 18, 2024 22:13
@Astrrra Astrrra marked this pull request as ready for review December 20, 2024 09:51
@Astrrra Astrrra requested a review from skotopes December 20, 2024 10:56
skotopes
skotopes previously approved these changes Dec 22, 2024
View reviewed changes
@skotopes skotopes merged commit a02781b into dev Dec 23, 2024
11 checks passed
@skotopes skotopes deleted the astra/3920-badble-fixes branch December 23, 2024 00:18
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Dec 23, 2024
@skotopes @RogueMaster
[FL-3920] Fix lost BadBLE keystrokes (flipperdevices#3993)
bb28ff9 
* WIP: fix lost BadBLE keystrokes
* Switch to semaphores for synchronization
* Move checking to the gap level
* Remove leftovers from hid_service
* Remove more leftovers from hid_service
* De-allocate the semaphore after use
* Change the timeout to account for unforeseen situation
* Update F18 API
* Fix naming and unbump api version
* Move away from semaphores
* Remove the left over include
* Ble: cleanup error handling in ble_gatt_characteristic_update
* Fix PVS warning

Co-authored-by: Aleksandr Kutuzov <alleteam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Astrrra @skotopes