Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skylander ID reading #4038

Merged
merged 4 commits into from
Dec 23, 2024

Merge branch 'dev' into raed_skylanders_faster

9919e88
Select commit
Loading
Failed to load commit list.
Merged

Fix skylander ID reading #4038

Merge branch 'dev' into raed_skylanders_faster
9919e88
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 23, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Fix parsing ID of skylanders. I think it was just pulling 1 byte and always getting a 0 for the high byte. Incomplete
read skylanders faster using known keys (https://nfc.toys/#new-interoperability-for-skylanders) Incomplete
Read Wildfire or Snap shot skylander and see they show up correctly (was incorrectly "Healing elixer" / "Winged boots") Incomplete
PR has description of feature/bug or link to Confluence/Jira task Completed
Description contains actions to verify feature/bugfix Completed
I've built this code, uploaded it to the device and verified feature/bugfix Completed