Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfc: Fix MFUL PWD_AUTH command creation #4051

Merged
merged 1 commit into from
Jan 10, 2025
Merged

nfc: Fix MFUL PWD_AUTH command creation #4051

merged 1 commit into from
Jan 10, 2025

Conversation

GMMan
Copy link
Contributor

@GMMan GMMan commented Dec 30, 2024 •
edited by skotopes
Loading

What's new

  • Prevents MFUL password from being truncated when it contains a null byte

Verification

  • Ensure that a MFUL variant with password authentication can be authenticated against when its password contains a null byte at offset 0, 1, or 2. At least one byte after the null byte should not be null.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes skotopes merged commit 668500e into flipperdevices:dev Jan 10, 2025
11 checks passed
Akiva-Cohen pushed a commit to Akiva-Cohen/flipperzero-firmware that referenced this pull request Jan 14, 2025
@GMMan @Akiva-Cohen
nfc: Fix MFUL PWD_AUTH command creation (flipperdevices#4051)
29e417e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMMan @skotopes