Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picopass cleanup #201

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Picopass cleanup #201

merged 4 commits into from
Apr 22, 2024

Conversation

bettse
Copy link
Collaborator

@bettse bettse commented Apr 12, 2024 •
edited by skotopes
Loading

What's new

  • Now that we have some block validation and auth method, using them in the read success and card menu

Verification

  • Try reading any picopass or iclass card. It should present reasonable information and reasonable save suggestions. No significant changes in information, but the credential is now bold where less important information is below it.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@bettse bettse marked this pull request as ready for review April 12, 2024 02:18
@bettse
Copy link
Collaborator Author

bettse commented Apr 18, 2024

this is ready to be looked at when someone has time

@skotopes
Copy link
Member

@bettse I'll merge it in a couple days

@skotopes skotopes merged commit 6664fe9 into flipperdevices:dev Apr 22, 2024
2 checks passed
@skotopes
Copy link
Member

Sorry for delay, got cold last week.

@bettse bettse deleted the picopass_cleanup branch April 22, 2024 01:36
@bettse
Copy link
Collaborator Author

bettse commented Apr 22, 2024

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

Assignees
No one assigned
Labels
app:picopass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bettse @skotopes