Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

New segment constraint fix #26

Merged
merged 3 commits into from
Jan 13, 2023
Merged

New segment constraint fix #26

merged 3 commits into from
Jan 13, 2023

Conversation

darinmclain
Copy link
Contributor

Removed selectedMatchType state variable, and converted the initialValue to be what the state used to be, and use formik's setFieldValue to update the matchType value. The error was being caused by the initialValue for matchType being a state variable and it would reset the form if it changed when creating a segment

Darin McLain added 2 commits January 12, 2023 21:22
…lue to be what the state used to be, and use formik's setFieldValue to update the matchType value. The error was being caused by the initialValue for matchType being a state variable and it would reset the form if it changed when creating a segment
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@markphelps markphelps merged commit e7cd62b into main Jan 13, 2023
@markphelps markphelps deleted the new-segment-constraint-fix branch January 13, 2023 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants