Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Bug: Rule creation with no variants should render help text #58

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Bug: Rule creation with no variants should render help text #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9b861e
Added extra check for variant length in case it comes in as an empty …
Jan 30, 2023
13c9f7e
Removed extra console.log for flag check
Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/rules/RuleForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export default function RuleForm(props: RuleFormProps) {
100% or less.
</p>
)}
{!flag.variants && (
{(!flag.variants || flag.variants?.length == 0) && (
<p className="mt-1 px-4 text-center text-sm text-gray-500 sm:px-6 sm:py-5">
Flag{' '}
<Link to={`/flags/${flag.key}`} className="text-violet-500">
Expand Down