fix: bucket prefix #3808
Merged
fix: bucket prefix #3808
+36
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
* main: fix: update flag with no metadata (#3791) chore(deps): bump github.com/jackc/pgx/v5 from 5.7.1 to 5.7.2 (#3786) chore(deps): bump go.opentelemetry.io/otel/exporters/prometheus (#3785) chore(deps): bump github.com/go-git/go-git/v5 from 5.13.0 to 5.13.1 (#3783) chore(deps): bump golang.org/x/oauth2 from 0.24.0 to 0.25.0 (#3784) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ecrpublic (#3787) chore(deps): bump class-variance-authority from 0.7.0 to 0.7.1 in /ui (#3782) chore(deps-dev): bump @types/node from 18.19.65 to 18.19.69 in /ui (#3780) chore(deps): bump @uiw/codemirror-theme-tokyo-night in /ui (#3779) chore(deps): bump react-chartjs-2 from 5.2.0 to 5.3.0 in /ui (#3778) chore(deps): bump next in /examples/nextjs/pages-router (#3776) chore(deps): bump next in /examples/nextjs/app-router (#3777) chore: add release-notes to gitignore chore: fix release notes build chore: prep 1.54 for release (#3775)
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
* 'main' of https://github.com/flipt-io/flipt: chore(deps): bump @fortawesome/fontawesome-svg-core in /ui (#3802) chore(deps): bump github.com/spf13/afero from 1.11.0 to 1.12.0 (#3799) chore(deps): bump golang.org/x/net from 0.33.0 to 0.34.0 (#3800) chore(deps): bump go.opentelemetry.io/otel/exporters/zipkin (#3796) chore(deps): bump cloud.google.com/go/storage from 1.49.0 to 1.50.0 (#3798) chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (#3797) chore(deps): bump alpine from 3.21.0 to 3.21.2 in /build (#3795) chore(deps): bump lucide-react from 0.468.0 to 0.471.0 in /ui (#3801) chore(deps-dev): bump @types/node from 18.19.69 to 18.19.70 in /ui (#3803) chore(deps): bump @fortawesome/free-brands-svg-icons in /ui (#3804) chore(deps): bump @codemirror/state from 6.5.0 to 6.5.1 in /ui (#3805) chore(deps): bump golang.org/x/tools from 0.28.0 to 0.29.0 in /_tools (#3793) chore(deps): bump google.golang.org/protobuf in /_tools (#3794) chore(deps-dev): bump eslint-plugin-react from 7.37.2 to 7.37.3 in /ui (#3781) chore: Add back release footer (#3792)
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
|
Prefix is a tricky thing. Prefix is not a folder as object storages doesn't have folders. At least in the past... AWS has changed this a bit recently. Prefixes |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3808 +/- ##
==========================================
- Coverage 64.84% 64.80% -0.05%
==========================================
Files 171 171
Lines 17391 17387 -4
==========================================
- Hits 11277 11267 -10
- Misses 5418 5423 +5
- Partials 696 697 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
I think the go cloud blob.PrefixedBucket should handle these cases no? At the very least all the ITs now pass again. Mind giving it a review @erka ? |
erka
reviewed
Jan 16, 2025
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
markphelps
added a commit
that referenced
this pull request
Jan 17, 2025
* 'main' of https://github.com/flipt-io/flipt: fix: bucket prefix (#3808)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: #3807
Re: #2589
It seems gcp was adding the prefix twice, so it would make requests like:
I assume this is because of us setting both the query param
prefixwhen building the bucket URL and by settingprefix+keyfor all object requests.I discovered that Go Cloud has support for prefixed buckets naturally: https://gocloud.dev/howto/blob/#prefix
Which now does the right thing and lists the contents at:
I still need to test if this breaks S3 prefix though