Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update flag with no metadata #3791

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix: update flag with no metadata #3791

merged 1 commit into from
Jan 10, 2025

Conversation

markphelps
Copy link
Collaborator

Fixes: #3789

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps requested a review from a team as a code owner January 10, 2025 18:20
@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (ad523ee) to head (f970b31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3791   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files         171      171           
  Lines       17391    17391           
=======================================
  Hits        11277    11277           
  Misses       5418     5418           
  Partials      696      696           
Flag Coverage Δ
unittests 64.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps merged commit 0b0e223 into main Jan 10, 2025
40 checks passed
@markphelps markphelps deleted the fix-metadata-update branch January 10, 2025 18:46
markphelps added a commit that referenced this pull request Jan 10, 2025
* main:
  fix: update flag with no metadata (#3791)
  chore(deps): bump github.com/jackc/pgx/v5 from 5.7.1 to 5.7.2 (#3786)
  chore(deps): bump go.opentelemetry.io/otel/exporters/prometheus (#3785)
  chore(deps): bump github.com/go-git/go-git/v5 from 5.13.0 to 5.13.1 (#3783)
  chore(deps): bump golang.org/x/oauth2 from 0.24.0 to 0.25.0 (#3784)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/ecrpublic (#3787)
  chore(deps): bump class-variance-authority from 0.7.0 to 0.7.1 in /ui (#3782)
  chore(deps-dev): bump @types/node from 18.19.65 to 18.19.69 in /ui (#3780)
  chore(deps): bump @uiw/codemirror-theme-tokyo-night in /ui (#3779)
  chore(deps): bump react-chartjs-2 from 5.2.0 to 5.3.0 in /ui (#3778)
  chore(deps): bump next in /examples/nextjs/pages-router (#3776)
  chore(deps): bump next in /examples/nextjs/app-router (#3777)
  chore: add release-notes to gitignore
  chore: fix release notes build
  chore: prep 1.54 for release (#3775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot update rollout from UI if flag has no metadata
1 participant