Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment search in match rule doesn't work #462

Closed
hagaishapira opened this issue Jun 3, 2021 · 5 comments · Fixed by #475
Closed

Segment search in match rule doesn't work #462

hagaishapira opened this issue Jun 3, 2021 · 5 comments · Fixed by #475
Labels

Comments

@hagaishapira
Copy link

Describe the bug
When setting up a new rule and looking for a segment to match typing anything doesn't seem to search or offer appropriate segments to match.

Version Info
v1.2.1

To Reproduce

  1. Create several segments
  2. Create a new flag
  3. Try to add a new rule to the flag. Typing in a portion of an existing segment name doesn't lead to showing only appropriate results.

Expected behavior
I expect that only appropriate segments that matched my typed input will show up in the dropdown list.

Screenshots
image
See how while I typed "hagai" I see the same results I've seen before typing anything.

Additional context
Add any other context about the problem here.

@markphelps
Copy link
Collaborator

Thanks for the bug report @hagaishapira ! I can confirm this same behavior. I will look into trying to fix this, likely an issue with the javascript library i'm using (buefy) to render this search

Screen Shot 2021-06-04 at 11 23 16 AM

@hagaishapira hagaishapira changed the title Segment search is match rule doesn't work Segment search in match rule doesn't work Jun 5, 2021
@markphelps
Copy link
Collaborator

@hagaishapira just fixed this in #475 and released a new version 1.3.0. please give it a try! and thanks again for the bug report

@hagaishapira
Copy link
Author

hagaishapira commented Jun 14, 2021 via email

@hagaishapira
Copy link
Author

@markphelps works great! This is has been a major pain point for the team for weeks now, we are all rejoiced.

@markphelps
Copy link
Collaborator

Great! glad to hear! It would be amazing if your company was able to help sponsor Flipt's development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants