Filtered GitHub webhooks #1018
Merged
Filtered GitHub webhooks #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
reviewed
Sep 8, 2022
markphelps
added a commit
that referenced
this pull request
Sep 22, 2022
* main: Update Changelog Bump sass from 1.54.9 to 1.55.0 in /ui (#1040) Bump @playwright/test from 1.25.2 to 1.26.0 in /ui (#1039) Bump eslint from 8.23.0 to 8.23.1 in /ui (#1037) Bump eslint-plugin-vue from 9.4.0 to 9.5.1 in /ui (#1034) Bump @babel/preset-env from 7.19.0 to 7.19.1 in /ui (#1033) Bump @babel/core from 7.19.0 to 7.19.1 in /ui (#1032) Fix clone icons (#1038) Bump buefy from 0.9.21 to 0.9.22 in /ui (#1022) Mv config internal (#1036) Filtered GitHub webhooks (#1018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt at filtering GitHub webhooks. This correctly filters out dependabot PRs, truncates long bodies (discord will fail the request if the body is too long).
Additionally, we're not trying to pass on the GitHub Webhook event body anymore, instead we're manually entering the embed fields. Due to this,
DISCORD_WEBHOOK_URLshould be updated to use the base Discord webhook URL.