Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testcontainer db #1045

Merged
merged 13 commits into from
Sep 28, 2022
Merged

Testcontainer db #1045

merged 13 commits into from
Sep 28, 2022

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Sep 28, 2022

Fixes FLI-19

Move mysql/postgres tests to use testcontainers. Allows us to more easily test mysql/postgres locally instead of depending on CI

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #1045 (8278a6a) into main (a3043b4) will decrease coverage by 0.33%.
The diff coverage is 46.66%.

@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   81.28%   80.95%   -0.34%     
==========================================
  Files          17       17              
  Lines        1817     1822       +5     
==========================================
- Hits         1477     1475       -2     
- Misses        265      271       +6     
- Partials       75       76       +1     
Impacted Files Coverage Δ
storage/sql/migrator.go 28.78% <0.00%> (ø)
storage/sql/db.go 87.73% <50.00%> (-6.33%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps merged commit 6fef58b into main Sep 28, 2022
@markphelps markphelps deleted the testcontainer-db branch September 28, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants