Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor telemetry, dont log warning if not able to report #1156

Merged
merged 4 commits into from
Nov 26, 2022

Conversation

markphelps
Copy link
Collaborator

Fixes: #1155

  • Don't log warning if telemetry cant run for whatever reason
  • Refactor telemetry a bit and push down most of the logic into telemetry package
  • Shuts down telemetry if it fails to report 3 times in a row

@markphelps markphelps requested a review from a team as a code owner November 23, 2022 16:24
Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One tiny correction.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2022

Codecov Report

Merging #1156 (e755d39) into main (1efd882) will decrease coverage by 1.05%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   80.08%   79.03%   -1.06%     
==========================================
  Files          36       36              
  Lines        2465     2518      +53     
==========================================
+ Hits         1974     1990      +16     
- Misses        394      430      +36     
- Partials       97       98       +1     
Impacted Files Coverage Δ
internal/telemetry/telemetry.go 53.62% <42.85%> (-14.62%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps markphelps merged commit b2cd6a6 into main Nov 26, 2022
@markphelps markphelps deleted the telemetry-refactor branch November 26, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry should not warn if .config directory is not writable
3 participants