fix(auth): mount core auth service via grpc gateway #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
- Coverage 79.02% 78.94% -0.09%
==========================================
Files 35 35
Lines 2508 2512 +4
==========================================
+ Hits 1982 1983 +1
- Misses 429 431 +2
- Partials 97 98 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
markphelps
approved these changes
Nov 28, 2022
GeorgeMac
added a commit
that referenced
this pull request
Nov 28, 2022
* fix(auth): mount core auth service via grpc gateway * fix(test): fallback to empty string when variable unbound * fix(test): cat -> echo * fix(test): reorder args to shakedown * fix(test): export FLIPT_TOKEN variable properly * fix(test): use jq -r to get unquoted string * fix(auth): register authentication service handler on gateway * fix(middleware): error interceptor forward grpc status errors * fix(test): adjust /auth/v1/self assertion on authentication requirement * fix(test): adjust if condition
markphelps
added a commit
that referenced
this pull request
Nov 28, 2022
…1175) (#1176) * fix(auth): mount core auth service via grpc gateway (#1175) * fix(auth): mount core auth service via grpc gateway * fix(test): fallback to empty string when variable unbound * fix(test): cat -> echo * fix(test): reorder args to shakedown * fix(test): export FLIPT_TOKEN variable properly * fix(test): use jq -r to get unquoted string * fix(auth): register authentication service handler on gateway * fix(middleware): error interceptor forward grpc status errors * fix(test): adjust /auth/v1/self assertion on authentication requirement * fix(test): adjust if condition * chore: rm it image (#1152) * chore: try to remove IT image * chore: rm node install where not needed * chore: try with sudo * chore: fix needs for API test * rm IT action * chore: try to fix build * chore: try to fix run commands * chore: try to fix run * Set e * chore: timeouts and sudo * chore: try to use uuidgen instead * Try 0.0.0.0 * Rm e * Try to fix redis test * always run log upload step * try to expose redis port on host * rm redis test * chore: update CHANGELOG Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markphelps noticed that the core auth service (list, self, getByID) was not actually mounted yet (my bad 🤦).
I added some test cases to the shakedown tests around these endpoints.
Along with mounting the service itself.
The tests should at-least avoid the regression of this in the future.
The tests: