feat(oidc): support generic OIDC providers #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
reviewed
Dec 14, 2022
internal/config/config.go
Outdated
| // time. | ||
| type trie map[string]trie | ||
|
|
||
| func (t trie) getPrefix(parts ...string) (trie, bool) { |
There was a problem hiding this comment.
could we add some more tests around this method and the function below it if possible?
There was a problem hiding this comment.
I've taken another pass in a slightly different way. Which also allowed me to test it more thoroughly.
It also accounts for something this implementation couldn't do. Which was keys in maps with _ in them.
See what you think.
Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## gm/oidc-google #1223 +/- ##
==================================================
+ Coverage 79.61% 79.81% +0.19%
==================================================
Files 40 40
Lines 3017 3076 +59
==================================================
+ Hits 2402 2455 +53
- Misses 496 499 +3
- Partials 119 122 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GeorgeMac
added a commit
that referenced
this pull request
Dec 22, 2022
* refactor(main): move grpc and http composition into internal/cmd * chore(internal/cmd): unexport grpc register types * chore(cmd/grpc): rename pushShutdown onShutdown and move clientConn to main * feat(oidc): implement Google OIDC provider feat(auth/oidc): implement authorize and callback refactor(oidc): switch to hashicorp/cap package test(oidc): add extra logging context for failure in CI chore: more test logging context chore: logging context around client cookie jar contents chore: print entire cookie jar fix(oidc): test use localhost over ip for cookie jar interactions chore: appears the linters refactor(internal/cmd): flatten bootstrapping package into one * chore(method/oidc): improve docs around http middleware * refactor(errors): add generic errors.NewErrorf * test(oidc): increase coverage around invalid state parameter on callback * chore: remove excess newline * fix(oidc): install missing auth middleware * feat(oidc): support generic OIDC providers (#1223) * feat(oidc): support generic OIDC providers * refactor(config): support maps with keys containing underscore * chore: appease the linters * chore(config): update doc string Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore(config): update bind function doc * feat(oidc): add more standard OIDC claims * chore(oidc): remove redundent return statement Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com> * chore(errors): restore Errorf helper functions * chore(errors): switch back to Errorf utility functions Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR based on the
gm/oidc-googlebranch. I thought I would propose it here first.If we like it, we can merge it into that and then merge that into
main.This makes the whole OIDC package generic for multiple providers.
The
providerskey is simply a map of any user-defined provider name to provider config.This leads to dynamic OIDC endpoints. e.g.
This will lead to the following endpoints:
I did a run through with Google, and it works as normal.