fix: disable csp headers in non-release mode for ui dev #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Looks good.
I think I see that because of the embedded Vite page serving at the entrypoint we have the same devtools problem.
We would have to run vite from the UI repo and not embed the vite page to get the experience I had imagined. Where we could leave these CSP headers untouched.
markphelps
added a commit
that referenced
this pull request
Jan 30, 2023
* main: fix: disable csp headers in non-release mode for ui dev (#1304)
markphelps
added a commit
that referenced
this pull request
Jan 31, 2023
* main: chore: bump prom verison (#1305) Otel improvements (#1306) fix: disable csp headers in non-release mode for ui dev (#1304) chore(deps): bump go.opentelemetry.io/otel/exporters/jaeger (#1299) chore(deps): bump google.golang.org/grpc from 1.52.0 to 1.52.3 (#1303) feat(logging): support custom time, level and message keys (#1295) fix: get linter running correctly locally (#1296) chore(deps): bump go.opentelemetry.io/otel from 1.11.2 to 1.12.0 (#1301) chore(deps): bump golangci/golangci-lint-action from 3.3.1 to 3.4.0 (#1298)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FLI-191
Don't set CSP header when running in development mode (version == "dev")
In the future I'd like to switch to some kind of 'mode' based logic, where we can more easily tell if Flipt is running locally for our development vs running in 'release' mode