feat: (sqlite) eval storage namespace support #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## namespaces #1372 +/- ##
=============================================
Coverage ? 79.83%
=============================================
Files ? 45
Lines ? 3585
Branches ? 0
=============================================
Hits ? 2862
Misses ? 577
Partials ? 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GeorgeMac
requested changes
Mar 3, 2023
internal/server/evaluator.go
Outdated
Comment on lines
81
to
83
| for _, req := range r.GetRequests() { | ||
| // ensure all requests have the same namespace | ||
| req.NamespaceKey = r.NamespaceKey |
There was a problem hiding this comment.
My gut says we probably should just reject a batch request if it contains get requests with namespaces which don't match the batch payload namespace.
Maybe we could at-least support implying a blank namespace in a child evaluate means inherits the parent batch request namespace?
What do you think?
There was a problem hiding this comment.
yeah that makes sense. in retrospect I should have made the batch API use it's own set of request objects which don't share the same properties with the EvaluateRequest.. but live and learn I guess. something to think about if we do a v2 API
markphelps
added a commit
that referenced
this pull request
Apr 5, 2023
* feat: (sqlite) support namespace at storage level, mostly for flags (#1368) * feat: (sqlite) wip support namespace at storage level, mostly for flags * chore: rename down namespace file correctly * chore: fix server/flag_test.go * chore: redo migration to use temp_tables for composite keys * chore: just use TODO for now for down migration * chore: comments * chore: wip namespace protos * chore: better err messages * Update internal/storage/sql/common/flag.go Co-authored-by: George <me@georgemac.com> * chore: fix tests * chore: split into seperate migrations * chore: more error messages * chore: rm println statment --------- Co-authored-by: George <me@georgemac.com> * feat: Namespaces segments storage (#1369) * feat: (sqlite) add namespace support for rules storage (#1371) * feat: (sqlite) eval storage namespace support (#1372) * Namespaces storage (#1383) * feat: wip namespace storage * chore: add tests; storage impl * chore: appease the linter * chore: less sleepy * Namespaces mysql (#1386) * feat: wip namespace storage * chore: add tests; storage impl * chore: appease the linter * feat: (wip) add namespace mysql migrations * chore: rename migrations * chore: rm empty migrations for the moment * chore: less sleepy * chore: 6 bytes for timestamp * chore: add rules migration * chore: add migration comments, revert local config * chore: reset mysql example * Namespaces postgres (#1388) * feat: (wip) postgres ddl * chore: fix tests * chore: disable container logging unless verbose env var passed * Namespaces cockroach (#1390) * feat: cockroachdb migrations * chore: fix migrations for cockroach * chore: namespaces down migrations (#1396) * Namespaces: flags storage tests (#1406) * Namespaces: segments storage tests (#1408) * chore: add segment namespace storage tests * chore: regen protos * chore: ignore sdk dir when fmting * chore: add remaining storage layer tests (#1412) * feat: add namespaces server mappings (#1415) * chore: add remaining storage layer tests * feat: add namespaces server mappings * chore: add back default namespace to otel metrics * chore: fix middleware test * Namespaces rpc (#1421) * feat: check for protected or flags existing when deleting a namespace (#1422) * feat: add namespaces server impl * chore: spacing * chore: rm ability to set protected * feat: check for protected or flags existing when deleting a namespace * chore: fix test * chore: add test for non-existing delete * feat(hack/build): add cases for namespace scoped integration tests (#1436) * chore: regenerate protobuf * feat(rpc/flipt): configure gateway routes for namespaces * feat(hack/build): add cases for namespace scoped integration tests * chore(rpc/flipt): remove TODO * chore(hack/build): use random string for namespace key * test(hack/build): ensure default namespace cannot be deleted * test(hack/build): ensure default namespace is protected but updateable * test(hack/build): ensure namespace with flags cannot be deleted * feat: add check for rule namespaced errors * fix: namespace segment REST API routes were not correct (#1445) * feat: add distribution test for cross-namespace entities * feat: leave namespace check to distribution * feat: generate namespaced scoped routes for distributions * chore: address changes in regards to error messaging * chore: abstract out the two types of DistributionRequests * fix(migrations/sqlite): reorder to ensure we copy all data before drop (#1446) * fix(migrations/sqlite): reorder to ensure we copy all data before drop * fix(migrations/sqlite): copy distributions into temp table before dropping everything * chore: do joins on the query and make error messages match * chore: merge main into namespaces (#1448) * chore(deps): bump go.opentelemetry.io/otel/exporters/zipkin (#1440) Bumps [go.opentelemetry.io/otel/exporters/zipkin](https://github.com/open-telemetry/opentelemetry-go) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.13.0...v1.14.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/zipkin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(github): dagger based integrations tests github workflow (#1428) * feat(github): install dagger based ITs as action workflow * fix(github): add workdir to mage action * chore(hack/build): bump dagger to 0.5.1 * chore: enable daggers experimental gha cache * chore(hack/build): reword test log lines * fix(github): move env var from legacy to experimental tests * chore(hack/build): arbitrary change to trigger rebuild * chore(github): remove experimental dagger cache env var * feat(hack/build): direct integration test flipt logs into directory * chore: empty commit to trigger CI * chore(hack/build): log error when failing to copy flipt logs * chore(hack/build): adding log line to integration test start * fix(github): stop caching entire hack build directory * refactor(hack/build): organize integration cases into test case struct * refactor(github): remove legacy API workflows and replace with dagger mage task * chore(hack/build): use protocolPorts map for test case iteration --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: add missing namespace metrics (#1450) * chore: allow testing of namespaces ui branch for build * chore: rm down migrations (#1449) * chore: wip rm down migrations * chore: fix tests * chore: fix tests; cleanup * chore: use new migrator on import if drop specified * chore: fix drop before import for sqlite * chore: move mysql fk disable into migrator down method * chore: codecov's last chance * feat(cmd): import and export namespace flag (#1452) * refactor(export): promote namespace to NewExporter argument * refactor(export): use GRPC service interface as exporter dependency * feat(export): support --export-from-address remote flipt address flag * refactor(cmd): share config as argument not global state * refactor(cmd/export): move command boostrapping from main.go to export.go * refactor(cmd): move signal trapping into main * refactor(cmd/import): move command boostrapping from main.go to import.go * refactor(ext): expose namespace as argument to NewImporter * feat(cmd/import): support remote import via --import-to-address * refactor(hack/build): restructure testing packages * refactor(hack/build): create import and export integration tests * feat(hack/build): more import integration test cases * feat(cmd/export): support --namespace flag * chore: go mod tidy * fix(cmd): do not close db early in import/export * refactor(cmd): rename import/export flags to --address and --token * refactor(cmd/import): move server config into server.go * fix(cmd/import): pass namespace key as name on create * fix(hack/build): assert returned namespace name is as expected * chore: validation logic for namespace requests (#1457) * chore: validation logic for namespace requests * chore: fix import command to use the namespace key as the name as well * chore: rm TODO comments in exporter * chore: mage proto * chore: update changelog for future namespace release; add mage proto lint check (#1460) * chore: trigger lint build * chore: rm mage proto check for now as its not working --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: George <me@georgemac.com> Co-authored-by: Yoofi Quansah <ybquansah@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: FLI-239
Like #1371 but for evaluation