Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create CI check for mage proto #1489

Merged
merged 2 commits into from
Apr 12, 2023
Merged

chore: create CI check for mage proto #1489

merged 2 commits into from
Apr 12, 2023

Conversation

yquansah
Copy link
Contributor

Due to the fact that mage proto can generate changes to the source code based of protobuf configuration, we would like to create a CI check to prevent users from forgetting to run this command when changes can be generated.

@yquansah yquansah requested a review from a team as a code owner April 11, 2023 20:42
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1489 (cbe47c5) into main (48b2571) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1489   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files          44       44           
  Lines        3402     3402           
=======================================
  Hits         2646     2646           
  Misses        603      603           
  Partials      153      153           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yquansah yquansah force-pushed the yq-mage-proto-gh branch 3 times, most recently from 2048674 to 386204a Compare April 11, 2023 21:08
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! for some reason i feel like myself or George tried something similar before but git state was always dirty ? maybe I'm misremembering, but either way this looks good!

Thank you!

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good. I feel like it shouldn't always be dirty and we should be able to run this.

@yquansah yquansah added the automerge Used by Kodiak bot to automerge PRs label Apr 12, 2023
@yquansah yquansah enabled auto-merge (squash) April 12, 2023 14:14
@yquansah yquansah merged commit 5069ba6 into main Apr 12, 2023
@yquansah yquansah deleted the yq-mage-proto-gh branch April 12, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants