Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): move hack/build into build #1493

Merged
merged 6 commits into from
Apr 14, 2023
Merged

feat(build): move hack/build into build #1493

merged 6 commits into from
Apr 14, 2023

Conversation

GeorgeMac
Copy link
Contributor

Fixes FLI-308

Moves hack/build contents into just build.

I fixed up a small break in the unit test workflow too.
This broke when we moved the UI back into this repository.
We're not currently running unit tests via dagger, just integration, so this went unnoticed.

@GeorgeMac GeorgeMac requested a review from a team as a code owner April 13, 2023 11:15
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1493 (5fc3985) into main (eb195f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files          46       46           
  Lines        3611     3611           
=======================================
  Hits         2809     2809           
  Misses        639      639           
  Partials      163      163           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. i'm getting some failures trying to run mage test:integration from within the build dir locally.. but it could just be a me/environmental thing

#4
#4 0.199 host alias: lookup 59ITLR5UJJHHI on 10.87.0.1:53: no such host
#4 0.422 host alias: lookup V65VEQ5F2IIHU on 10.87.0.1:53: no such host
#4 0.448 host alias: lookup 2LT67EKMRPRLU on 10.87.0.1:53: no such host
#4 ...

@GeorgeMac
Copy link
Contributor Author

lgtm.. i'm getting some failures trying to run mage test:integration from within the build dir locally.. but it could just be a me/environmental thing

#4
#4 0.199 host alias: lookup 59ITLR5UJJHHI on 10.87.0.1:53: no such host
#4 0.422 host alias: lookup V65VEQ5F2IIHU on 10.87.0.1:53: no such host
#4 0.448 host alias: lookup 2LT67EKMRPRLU on 10.87.0.1:53: no such host
#4 ...

Hmm strange, I haven't managed to replicate that. I have seen that particular error before, it has to do with the WithService functionality and its built in healthchecks I believe. Hopefully just a transient thing and something which hardens over time with new Dagger releases.

@GeorgeMac GeorgeMac added the automerge Used by Kodiak bot to automerge PRs label Apr 14, 2023
@kodiakhq kodiakhq bot merged commit 37a3fe7 into main Apr 14, 2023
@kodiakhq kodiakhq bot deleted the gm/move-hack-build branch April 14, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants