automatically populate the key field based on the flag name #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the flag name input is updated a check is done to see if the flag key is either empty or the same as the flag name. If so, the flag key will be updateed accordingly. This check is done to ensure that custom keys are not overriden when changing the flag name.
aaronraff
commented
Oct 6, 2019
|
This is dope. Thanks @aaronraff! I'm gonna copy this impl to the segment form as well as I forgot to add that as part of the issue. Also FYI, im working on a branch/PR to switch to gobuffalo/packr for embedding the assets, which will get rid of the Thanks again! |
This was referenced Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #136
Whenever the flag name input is updated a check is done to see if
the flag key is either empty or the same as the flag name. If so,
the flag key will be updated accordingly. This check is done to
ensure that custom keys are not overridden when changing the flag
name.
This also moves the flag name field above the flag key field when creating a new flag.