Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent segment matching #168

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Fix inconsistent segment matching #168

merged 2 commits into from
Nov 9, 2019

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Nov 8, 2019 •
edited
Loading

Fixes: #166

Was ranging over a map of rules which is inconsistent per the spec:

The iteration order over maps is not specified and is not guaranteed to be the same from one iteration to the next.

@markphelps markphelps added the wip Work In Progress label Nov 8, 2019
@markphelps markphelps self-assigned this Nov 8, 2019
@markphelps markphelps changed the title Wip: fix inconsistent segment matching Fix inconsistent segment matching Nov 9, 2019
@markphelps markphelps removed the wip Work In Progress label Nov 9, 2019
@markphelps markphelps merged commit 38eaa75 into master Nov 9, 2019
@markphelps markphelps deleted the inconsistent-match branch November 9, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markphelps markphelps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent match when percentage rollout and match all rules are used together
1 participant
@markphelps