Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cross namespaced constraints #1721

Merged
merged 5 commits into from
Jun 8, 2023
Merged

fix: cross namespaced constraints #1721

merged 5 commits into from
Jun 8, 2023

Conversation

markphelps
Copy link
Collaborator

fixes bug where we werent using the namespace_key when looking up constraints for segments

@markphelps markphelps requested a review from a team as a code owner June 8, 2023 20:18
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@965e1cb). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 246a974 differs from pull request most recent head 4edde1c. Consider uploading reports for the commit 4edde1c to get more accurate results

@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage        ?   79.20%           
=======================================
  Files           ?       48           
  Lines           ?     3952           
  Branches        ?        0           
=======================================
  Hits            ?     3130           
  Misses          ?      653           
  Partials        ?      169           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@markphelps
Copy link
Collaborator Author

adding tests decreases coverage. go home CodeCov you're drunk

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jun 8, 2023
@markphelps
Copy link
Collaborator Author

wondering if we should backport to the 1.22 branch and create a new bugfix release?

@kodiakhq kodiakhq bot merged commit 9ef7792 into main Jun 8, 2023
@kodiakhq kodiakhq bot deleted the fix-cross-constraints branch June 8, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants