feat: new evaluation routes #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(wip): rollout for boolean flags * feat(wip): strategy impl * feat: rollout rules > rollout strategy * chore: add namespace_key to tables * feat: list rules * feat: impl delete * chore: rm debug logs * chore: rename things * chore: compiles, start adding storage tests * feat(wip): update rollout * chore: compiles * chore: compiles/finish sqlite rollout tests for now * chore: fix countRollouts call * chore: rebase eval-v2 * chore: checkout ui from main * chore: replace ui with ui from main * chore: fix buflint * chore: fix lint errors * chore: rowserrcheck * chore: mage proto
* feat: implement gRPC server for the Variant RPC method * chore: rename Server field to evaluator * chore: move around tests, and other fixes * chore: DRY up middleware and add extra field to otel metrics * test(integration): ensure Evaluation.Variant returns as expected (#1800) * test(integration/api): ensure Evaluation.Variant returns as expected * test(integration/readonly): ensure Evaluation.Variant returns as expected * fix(build/testing): set production yaml version to 1.0 * fix(build/testing/api): ensure disabled flag is created and listed * fix(build/testing/api): fix disabled flag asserts and delete before ns is deleted * fix(build/testdata): typo on name field case * fix(server/middleware): set request IDs on evaluation req/resp type * fix(build/integration): ensure 51 flags exist * fix(build/integration): ensure flag not found error is returned * fix(build/integration): explicitly set enabled false in testdata * chore: rearrange some files and make some new declarations * chore: move around some structures and address other feedback around passing flag into Evaluate * chore: set timestamps and request id on Variant responses * chore: add test and move invalid flag type to evaluator --------- Co-authored-by: George <me@georgemac.com>
feat: v2 evaluate boolean
* test(integration/api): ensure Boolean type flag create * fix(api/rollouts): ensure tx rollback and drop create rollout type * fix(storage/rollout): ensure tx rollback and fixed rollout type on update * fix(storage/sql/rollout): validate rule is supplied on create * chore(rpc): add rollout request types validation * fix(integration/readonly): add flag_disabled to end of set * chore: commit proto version comment updates
Codecov Report
@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 71.30% 71.35% +0.04%
==========================================
Files 61 66 +5
Lines 5820 6455 +635
==========================================
+ Hits 4150 4606 +456
- Misses 1436 1592 +156
- Partials 234 257 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
refactor!(rpc/flipt): rename RolloutPercentage to RolloutThreshold
* chore: fix screenshots for new ui * chore: mv screenshots to subdir * feat(wip): concepts docs * chore: rm old screenshots func * chore: finish most of the screenshots * chore: add rollouts * chore: add readonly screenshot * chore: add missing eval console screen
* 'main' of https://github.com/flipt-io/flipt: docs: add ahobson as a contributor for code (#1905)
* 'main' of https://github.com/flipt-io/flipt: feat: unhide validate command (#1909)
* 'main' of https://github.com/flipt-io/flipt: chore(deps): bump github.com/grpc-ecosystem/grpc-gateway/v2 (#1908) chore(deps): bump github.com/hashicorp/cap from 0.3.2 to 0.3.3 (#1906) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#1907)
* main: chore(tests): add tests for matching and non-matching of regexs chore(auth): Address comments related to pre-compiling regexs chore(auth): Address PR changes and accommodate with tests chore(auth): use comma for splitting feat(email): Add email matching logic for whitelisting OIDC
* chore: fix scrollToBottom for screenshots * chore: increase sleep by 1s
* 'main' of https://github.com/flipt-io/flipt: docs: add rudineirk as a contributor for code (#1913) perf: add cache to get evaluation rules storage method (#1910) fix: renable pprof (#1912)
* chore: fix cacher interceptor ordering * chore: fix storage cacher tests (#1916) * chore: why are you changing go.work.sum * chore: fixup cacher tests into new eval-v2 branch * chore: rm unknown file
markphelps
approved these changes
Jul 28, 2023
markphelps
added a commit
that referenced
this pull request
Jul 28, 2023
* 'main' of https://github.com/flipt-io/flipt: feat: new evaluation routes (#1824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long lived branch which will stay drafted until we've gotten through the bulk of the changes to build the new eval routes.
Fixes: #368
Fixes: #1351
Fixes: FLI-230