Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string constraint fixes #193

Merged
merged 12 commits into from
Nov 28, 2019
Merged

Empty string constraint fixes #193

merged 12 commits into from
Nov 28, 2019

Conversation

markphelps
Copy link
Collaborator

  • Fix issue where != would evaluate to true if constraint value was not present
  • Require value for constraints unless operator is one of [empty, not empty, present, not present]
  • Move validation into middleware
  • Move errors into own package

@markphelps markphelps merged commit 434a58b into master Nov 28, 2019
@markphelps markphelps deleted the empty-string-constraint-fixes branch November 28, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markphelps