feat(config/flipt.schema.*): add oidc provider scopes property #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
approved these changes
Aug 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #1946 +/- ##
=======================================
Coverage 71.07% 71.07%
=======================================
Files 67 67
Lines 6541 6541
=======================================
Hits 4649 4649
Misses 1629 1629
Partials 263 263 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@all-contributors please add @Provinite for code |
|
I've put up a pull request to add @Provinite! 🎉 |
yquansah
pushed a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional string array field definition for the
authentication.methods.oidc.providers.[provider].scopesoption to the JSON and CUE schemas for the flipt configuration file.Notes
I wasn't sure if it was preferable to just use a loose string type, or if a specific enum with the standard OIDC claims of
email,profilewould be more correct. Let me know if you'd prefer it as an enum instead and I can update.On CUE
I have no experience with CUE schemas or idea of how to go about validating my change. I read up on the docs and this seemed like the right change there. Apologies if this is making more work than it's resolving 😆.
Thanks for the warm response!
Related Issue
Fixes #1944